Skip to content

Make highlight pagination independent of snapshot ids#47

Merged
softpudding merged 8 commits intomainfrom
codex/highlight-page-pagination
Mar 28, 2026
Merged

Make highlight pagination independent of snapshot ids#47
softpudding merged 8 commits intomainfrom
codex/highlight-page-pagination

Conversation

@softpudding
Copy link
Copy Markdown
Owner

Summary

  • make highlight pagination depend only on page number and current page state
  • return a fresh highlight_snapshot_id for each highlight result and keep snapshot ids only for later element actions
  • update prompts, docs, tests, agent-sdk pin, and include eval/evaluation_report.json

Testing

  • uv run pytest server/tests/unit/test_command_models.py server/tests/unit/test_prompt_contracts.py server/tests/unit/test_agent_browser_executor.py
  • bun test extension/src/commands/tests/element-id.test.ts
  • npm run build
  • manual validation of the DataFlow eval flow

@softpudding softpudding merged commit 37b5575 into main Mar 28, 2026
4 checks passed
@softpudding softpudding deleted the codex/highlight-page-pagination branch April 1, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant